logging and diagnostic features added

internal/httpapp/app.go

@@ -10,8 +10,10 @@ import (
 
 	"gitea.avt.data-center.id/othman.suseno/atlas/internal/audit"
 	"gitea.avt.data-center.id/othman.suseno/atlas/internal/auth"
+	"gitea.avt.data-center.id/othman.suseno/atlas/internal/backup"
 	"gitea.avt.data-center.id/othman.suseno/atlas/internal/db"
 	"gitea.avt.data-center.id/othman.suseno/atlas/internal/job"
+	"gitea.avt.data-center.id/othman.suseno/atlas/internal/metrics"
 	"gitea.avt.data-center.id/othman.suseno/atlas/internal/services"
 	"gitea.avt.data-center.id/othman.suseno/atlas/internal/snapshot"
 	"gitea.avt.data-center.id/othman.suseno/atlas/internal/storage"
@@ -26,23 +28,26 @@ type Config struct {
 }
 
 type App struct {
-	cfg            Config
-	tmpl           *template.Template
-	mux            *http.ServeMux
-	zfs            *zfs.Service
-	snapshotPolicy *snapshot.PolicyStore
-	jobManager     *job.Manager
-	scheduler      *snapshot.Scheduler
-	authService    *auth.Service
-	userStore      *auth.UserStore
-	auditStore     *audit.Store
-	smbStore       *storage.SMBStore
-	nfsStore       *storage.NFSStore
-	iscsiStore     *storage.ISCSIStore
-	database       *db.DB // Optional database connection
-	smbService     *services.SMBService
-	nfsService     *services.NFSService
-	iscsiService   *services.ISCSIService
+	cfg              Config
+	tmpl             *template.Template
+	mux              *http.ServeMux
+	zfs              *zfs.Service
+	snapshotPolicy   *snapshot.PolicyStore
+	jobManager       *job.Manager
+	scheduler        *snapshot.Scheduler
+	authService      *auth.Service
+	userStore        *auth.UserStore
+	auditStore       *audit.Store
+	smbStore         *storage.SMBStore
+	nfsStore         *storage.NFSStore
+	iscsiStore       *storage.ISCSIStore
+	database         *db.DB // Optional database connection
+	smbService       *services.SMBService
+	nfsService       *services.NFSService
+	iscsiService     *services.ISCSIService
+	metricsCollector *metrics.Collector
+	startTime        time.Time
+	backupService    *backup.Service
 }
 
 func New(cfg Config) (*App, error) {
@@ -91,24 +96,41 @@ func New(cfg Config) (*App, error) {
 	nfsService := services.NewNFSService()
 	iscsiService := services.NewISCSIService()
 
+	// Initialize metrics collector
+	metricsCollector := metrics.NewCollector()
+	startTime := time.Now()
+
+	// Initialize backup service
+	backupDir := os.Getenv("ATLAS_BACKUP_DIR")
+	if backupDir == "" {
+		backupDir = "data/backups"
+	}
+	backupService, err := backup.New(backupDir)
+	if err != nil {
+		return nil, fmt.Errorf("init backup service: %w", err)
+	}
+
 	a := &App{
-		cfg:            cfg,
-		tmpl:           tmpl,
-		mux:            http.NewServeMux(),
-		zfs:            zfsService,
-		snapshotPolicy: policyStore,
-		jobManager:     jobMgr,
-		scheduler:      scheduler,
-		authService:    authService,
-		userStore:      userStore,
-		auditStore:     auditStore,
-		smbStore:       smbStore,
-		nfsStore:       nfsStore,
-		iscsiStore:     iscsiStore,
-		database:       database,
-		smbService:     smbService,
-		nfsService:     nfsService,
-		iscsiService:   iscsiService,
+		cfg:              cfg,
+		tmpl:             tmpl,
+		mux:              http.NewServeMux(),
+		zfs:              zfsService,
+		snapshotPolicy:   policyStore,
+		jobManager:       jobMgr,
+		scheduler:        scheduler,
+		authService:      authService,
+		userStore:        userStore,
+		auditStore:       auditStore,
+		smbStore:         smbStore,
+		nfsStore:         nfsStore,
+		iscsiStore:       iscsiStore,
+		database:         database,
+		smbService:       smbService,
+		nfsService:       nfsService,
+		iscsiService:     iscsiService,
+		metricsCollector: metricsCollector,
+		startTime:        startTime,
+		backupService:    backupService,
 	}
 
 	// Start snapshot scheduler (runs every 15 minutes)
@@ -119,8 +141,37 @@ func New(cfg Config) (*App, error) {
 }
 
 func (a *App) Router() http.Handler {
-	// Wrap the mux with middleware chain: requestID -> logging -> audit -> auth
-	return requestID(logging(a.auditMiddleware(a.authMiddleware(a.mux))))
+	// Middleware chain order (outer to inner):
+	// 1. CORS (handles preflight)
+	// 2. Security headers
+	// 3. Request size limit (10MB)
+	// 4. Content-Type validation
+	// 5. Rate limiting
+	// 6. Error recovery
+	// 7. Request ID
+	// 8. Logging
+	// 9. Audit
+	// 10. Authentication
+	// 11. Routes
+	return a.corsMiddleware(
+		a.securityHeadersMiddleware(
+			a.requestSizeMiddleware(10 * 1024 * 1024)(
+				a.validateContentTypeMiddleware(
+					a.rateLimitMiddleware(
+						a.errorMiddleware(
+							requestID(
+								logging(
+									a.auditMiddleware(
+										a.authMiddleware(a.mux),
+									),
+								),
+							),
+						),
+					),
+				),
+			),
+		),
+	)
 }
 
 // StopScheduler stops the snapshot scheduler (for graceful shutdown)