othman.suseno/vtl-appliance
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: Use absolute paths and update sudoers for systemctl/lsscsi

Browse Source
This commit is contained in:
othman hendy suseno
2025-12-09 18:33:03 +00:00
parent 6c5ec902ca
commit 5746891b3c
6 changed files with 83 additions and 91 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
config/mhvtl-sudoers
View File

@@ -1,37 +1,41 @@
# Allow www-data to restart mhvtl service without password # Allow www-data to restart mhvtl service without password
www-data ALL=(ALL) NOPASSWD: /bin/systemctl restart mhvtl www-data ALL=(ALL) NOPASSWD: /bin/systemctl restart mhvtl, /usr/bin/systemctl restart mhvtl
www-data ALL=(ALL) NOPASSWD: /bin/systemctl start mhvtl www-data ALL=(ALL) NOPASSWD: /bin/systemctl start mhvtl, /usr/bin/systemctl start mhvtl
www-data ALL=(ALL) NOPASSWD: /bin/systemctl stop mhvtl www-data ALL=(ALL) NOPASSWD: /bin/systemctl stop mhvtl, /usr/bin/systemctl stop mhvtl
www-data ALL=(ALL) NOPASSWD: /bin/systemctl status mhvtl www-data ALL=(ALL) NOPASSWD: /bin/systemctl status mhvtl, /usr/bin/systemctl status mhvtl
www-data ALL=(ALL) NOPASSWD: /bin/systemctl is-active mhvtl www-data ALL=(ALL) NOPASSWD: /bin/systemctl is-active mhvtl, /usr/bin/systemctl is-active mhvtl
www-data ALL=(ALL) NOPASSWD: /bin/systemctl is-enabled mhvtl www-data ALL=(ALL) NOPASSWD: /bin/systemctl is-enabled mhvtl, /usr/bin/systemctl is-enabled mhvtl
www-data ALL=(ALL) NOPASSWD: /bin/systemctl status apache2 www-data ALL=(ALL) NOPASSWD: /bin/systemctl status apache2, /usr/bin/systemctl status apache2
www-data ALL=(ALL) NOPASSWD: /bin/systemctl is-active apache2 www-data ALL=(ALL) NOPASSWD: /bin/systemctl is-active apache2, /usr/bin/systemctl is-active apache2
www-data ALL=(ALL) NOPASSWD: /bin/systemctl is-enabled apache2 www-data ALL=(ALL) NOPASSWD: /bin/systemctl is-enabled apache2, /usr/bin/systemctl is-enabled apache2
www-data ALL=(ALL) NOPASSWD: /bin/systemctl status tgt www-data ALL=(ALL) NOPASSWD: /bin/systemctl status tgt, /usr/bin/systemctl status tgt
www-data ALL=(ALL) NOPASSWD: /bin/systemctl is-active tgt www-data ALL=(ALL) NOPASSWD: /bin/systemctl is-active tgt, /usr/bin/systemctl is-active tgt
www-data ALL=(ALL) NOPASSWD: /bin/systemctl is-enabled tgt www-data ALL=(ALL) NOPASSWD: /bin/systemctl is-enabled tgt, /usr/bin/systemctl is-enabled tgt
www-data ALL=(ALL) NOPASSWD: /bin/rm -rf /opt/mhvtl/* www-data ALL=(ALL) NOPASSWD: /bin/rm -rf /opt/mhvtl/*, /usr/bin/rm -rf /opt/mhvtl/*
www-data ALL=(ALL) NOPASSWD: /usr/sbin/tgtadm www-data ALL=(ALL) NOPASSWD: /usr/sbin/tgtadm
www-data ALL=(ALL) NOPASSWD: /usr/bin/lsscsi www-data ALL=(ALL) NOPASSWD: /usr/bin/lsscsi
www-data ALL=(ALL) NOPASSWD: /tmp/restart-appliance.sh www-data ALL=(ALL) NOPASSWD: /tmp/restart-appliance.sh
www-data ALL=(ALL) NOPASSWD: /tmp/shutdown-appliance.sh www-data ALL=(ALL) NOPASSWD: /tmp/shutdown-appliance.sh
www-data ALL=(ALL) NOPASSWD: /usr/bin/systemctl reboot
www-data ALL=(ALL) NOPASSWD: /usr/bin/systemctl poweroff
# Allow apache to restart mhvtl service without password (for RPM-based systems) # Allow apache to restart mhvtl service without password (for RPM-based systems)
apache ALL=(ALL) NOPASSWD: /bin/systemctl restart mhvtl apache ALL=(ALL) NOPASSWD: /bin/systemctl restart mhvtl, /usr/bin/systemctl restart mhvtl
apache ALL=(ALL) NOPASSWD: /bin/systemctl start mhvtl apache ALL=(ALL) NOPASSWD: /bin/systemctl start mhvtl, /usr/bin/systemctl start mhvtl
apache ALL=(ALL) NOPASSWD: /bin/systemctl stop mhvtl apache ALL=(ALL) NOPASSWD: /bin/systemctl stop mhvtl, /usr/bin/systemctl stop mhvtl
apache ALL=(ALL) NOPASSWD: /bin/systemctl status mhvtl apache ALL=(ALL) NOPASSWD: /bin/systemctl status mhvtl, /usr/bin/systemctl status mhvtl
apache ALL=(ALL) NOPASSWD: /bin/systemctl is-active mhvtl apache ALL=(ALL) NOPASSWD: /bin/systemctl is-active mhvtl, /usr/bin/systemctl is-active mhvtl
apache ALL=(ALL) NOPASSWD: /bin/systemctl is-enabled mhvtl apache ALL=(ALL) NOPASSWD: /bin/systemctl is-enabled mhvtl, /usr/bin/systemctl is-enabled mhvtl
apache ALL=(ALL) NOPASSWD: /bin/systemctl status httpd apache ALL=(ALL) NOPASSWD: /bin/systemctl status httpd, /usr/bin/systemctl status httpd
apache ALL=(ALL) NOPASSWD: /bin/systemctl is-active httpd apache ALL=(ALL) NOPASSWD: /bin/systemctl is-active httpd, /usr/bin/systemctl is-active httpd
apache ALL=(ALL) NOPASSWD: /bin/systemctl is-enabled httpd apache ALL=(ALL) NOPASSWD: /bin/systemctl is-enabled httpd, /usr/bin/systemctl is-enabled httpd
apache ALL=(ALL) NOPASSWD: /bin/systemctl status scsi-target-utils apache ALL=(ALL) NOPASSWD: /bin/systemctl status scsi-target-utils, /usr/bin/systemctl status scsi-target-utils
apache ALL=(ALL) NOPASSWD: /bin/systemctl is-active scsi-target-utils apache ALL=(ALL) NOPASSWD: /bin/systemctl is-active scsi-target-utils, /usr/bin/systemctl is-active scsi-target-utils
apache ALL=(ALL) NOPASSWD: /bin/systemctl is-enabled scsi-target-utils apache ALL=(ALL) NOPASSWD: /bin/systemctl is-enabled scsi-target-utils, /usr/bin/systemctl is-enabled scsi-target-utils
apache ALL=(ALL) NOPASSWD: /bin/rm -rf /opt/mhvtl/* apache ALL=(ALL) NOPASSWD: /bin/rm -rf /opt/mhvtl/*, /usr/bin/rm -rf /opt/mhvtl/*
apache ALL=(ALL) NOPASSWD: /usr/sbin/tgtadm apache ALL=(ALL) NOPASSWD: /usr/sbin/tgtadm
apache ALL=(ALL) NOPASSWD: /usr/bin/lsscsi apache ALL=(ALL) NOPASSWD: /usr/bin/lsscsi
apache ALL=(ALL) NOPASSWD: /tmp/restart-appliance.sh apache ALL=(ALL) NOPASSWD: /tmp/restart-appliance.sh
apache ALL=(ALL) NOPASSWD: /tmp/shutdown-appliance.sh apache ALL=(ALL) NOPASSWD: /tmp/shutdown-appliance.sh
apache ALL=(ALL) NOPASSWD: /usr/bin/systemctl reboot
apache ALL=(ALL) NOPASSWD: /usr/bin/systemctl poweroff

BIN
dist/adastra-vtl-installer-1.0.0.tar.gz vendored
View File

Binary file not shown.

2
dist/adastra-vtl-installer/VERSION vendored
View File

@@ -1,4 +1,4 @@
Adastra VTL Installer Adastra VTL Installer
Version: 1.0.0 Version: 1.0.0
Build Date: 2025-12-09 18:21:12 Build Date: 2025-12-09 18:33:03
Build Host: vtl-dev Build Host: vtl-dev

56
dist/adastra-vtl-installer/config/mhvtl-sudoers vendored
View File

@@ -1,37 +1,41 @@
# Allow www-data to restart mhvtl service without password # Allow www-data to restart mhvtl service without password
www-data ALL=(ALL) NOPASSWD: /bin/systemctl restart mhvtl www-data ALL=(ALL) NOPASSWD: /bin/systemctl restart mhvtl, /usr/bin/systemctl restart mhvtl
www-data ALL=(ALL) NOPASSWD: /bin/systemctl start mhvtl www-data ALL=(ALL) NOPASSWD: /bin/systemctl start mhvtl, /usr/bin/systemctl start mhvtl
www-data ALL=(ALL) NOPASSWD: /bin/systemctl stop mhvtl www-data ALL=(ALL) NOPASSWD: /bin/systemctl stop mhvtl, /usr/bin/systemctl stop mhvtl
www-data ALL=(ALL) NOPASSWD: /bin/systemctl status mhvtl www-data ALL=(ALL) NOPASSWD: /bin/systemctl status mhvtl, /usr/bin/systemctl status mhvtl
www-data ALL=(ALL) NOPASSWD: /bin/systemctl is-active mhvtl www-data ALL=(ALL) NOPASSWD: /bin/systemctl is-active mhvtl, /usr/bin/systemctl is-active mhvtl
www-data ALL=(ALL) NOPASSWD: /bin/systemctl is-enabled mhvtl www-data ALL=(ALL) NOPASSWD: /bin/systemctl is-enabled mhvtl, /usr/bin/systemctl is-enabled mhvtl
www-data ALL=(ALL) NOPASSWD: /bin/systemctl status apache2 www-data ALL=(ALL) NOPASSWD: /bin/systemctl status apache2, /usr/bin/systemctl status apache2
www-data ALL=(ALL) NOPASSWD: /bin/systemctl is-active apache2 www-data ALL=(ALL) NOPASSWD: /bin/systemctl is-active apache2, /usr/bin/systemctl is-active apache2
www-data ALL=(ALL) NOPASSWD: /bin/systemctl is-enabled apache2 www-data ALL=(ALL) NOPASSWD: /bin/systemctl is-enabled apache2, /usr/bin/systemctl is-enabled apache2
www-data ALL=(ALL) NOPASSWD: /bin/systemctl status tgt www-data ALL=(ALL) NOPASSWD: /bin/systemctl status tgt, /usr/bin/systemctl status tgt
www-data ALL=(ALL) NOPASSWD: /bin/systemctl is-active tgt www-data ALL=(ALL) NOPASSWD: /bin/systemctl is-active tgt, /usr/bin/systemctl is-active tgt
www-data ALL=(ALL) NOPASSWD: /bin/systemctl is-enabled tgt www-data ALL=(ALL) NOPASSWD: /bin/systemctl is-enabled tgt, /usr/bin/systemctl is-enabled tgt
www-data ALL=(ALL) NOPASSWD: /bin/rm -rf /opt/mhvtl/* www-data ALL=(ALL) NOPASSWD: /bin/rm -rf /opt/mhvtl/*, /usr/bin/rm -rf /opt/mhvtl/*
www-data ALL=(ALL) NOPASSWD: /usr/sbin/tgtadm www-data ALL=(ALL) NOPASSWD: /usr/sbin/tgtadm
www-data ALL=(ALL) NOPASSWD: /usr/bin/lsscsi www-data ALL=(ALL) NOPASSWD: /usr/bin/lsscsi
www-data ALL=(ALL) NOPASSWD: /tmp/restart-appliance.sh www-data ALL=(ALL) NOPASSWD: /tmp/restart-appliance.sh
www-data ALL=(ALL) NOPASSWD: /tmp/shutdown-appliance.sh www-data ALL=(ALL) NOPASSWD: /tmp/shutdown-appliance.sh
www-data ALL=(ALL) NOPASSWD: /usr/bin/systemctl reboot
www-data ALL=(ALL) NOPASSWD: /usr/bin/systemctl poweroff
# Allow apache to restart mhvtl service without password (for RPM-based systems) # Allow apache to restart mhvtl service without password (for RPM-based systems)
apache ALL=(ALL) NOPASSWD: /bin/systemctl restart mhvtl apache ALL=(ALL) NOPASSWD: /bin/systemctl restart mhvtl, /usr/bin/systemctl restart mhvtl
apache ALL=(ALL) NOPASSWD: /bin/systemctl start mhvtl apache ALL=(ALL) NOPASSWD: /bin/systemctl start mhvtl, /usr/bin/systemctl start mhvtl
apache ALL=(ALL) NOPASSWD: /bin/systemctl stop mhvtl apache ALL=(ALL) NOPASSWD: /bin/systemctl stop mhvtl, /usr/bin/systemctl stop mhvtl
apache ALL=(ALL) NOPASSWD: /bin/systemctl status mhvtl apache ALL=(ALL) NOPASSWD: /bin/systemctl status mhvtl, /usr/bin/systemctl status mhvtl
apache ALL=(ALL) NOPASSWD: /bin/systemctl is-active mhvtl apache ALL=(ALL) NOPASSWD: /bin/systemctl is-active mhvtl, /usr/bin/systemctl is-active mhvtl
apache ALL=(ALL) NOPASSWD: /bin/systemctl is-enabled mhvtl apache ALL=(ALL) NOPASSWD: /bin/systemctl is-enabled mhvtl, /usr/bin/systemctl is-enabled mhvtl
apache ALL=(ALL) NOPASSWD: /bin/systemctl status httpd apache ALL=(ALL) NOPASSWD: /bin/systemctl status httpd, /usr/bin/systemctl status httpd
apache ALL=(ALL) NOPASSWD: /bin/systemctl is-active httpd apache ALL=(ALL) NOPASSWD: /bin/systemctl is-active httpd, /usr/bin/systemctl is-active httpd
apache ALL=(ALL) NOPASSWD: /bin/systemctl is-enabled httpd apache ALL=(ALL) NOPASSWD: /bin/systemctl is-enabled httpd, /usr/bin/systemctl is-enabled httpd
apache ALL=(ALL) NOPASSWD: /bin/systemctl status scsi-target-utils apache ALL=(ALL) NOPASSWD: /bin/systemctl status scsi-target-utils, /usr/bin/systemctl status scsi-target-utils
apache ALL=(ALL) NOPASSWD: /bin/systemctl is-active scsi-target-utils apache ALL=(ALL) NOPASSWD: /bin/systemctl is-active scsi-target-utils, /usr/bin/systemctl is-active scsi-target-utils
apache ALL=(ALL) NOPASSWD: /bin/systemctl is-enabled scsi-target-utils apache ALL=(ALL) NOPASSWD: /bin/systemctl is-enabled scsi-target-utils, /usr/bin/systemctl is-enabled scsi-target-utils
apache ALL=(ALL) NOPASSWD: /bin/rm -rf /opt/mhvtl/* apache ALL=(ALL) NOPASSWD: /bin/rm -rf /opt/mhvtl/*, /usr/bin/rm -rf /opt/mhvtl/*
apache ALL=(ALL) NOPASSWD: /usr/sbin/tgtadm apache ALL=(ALL) NOPASSWD: /usr/sbin/tgtadm
apache ALL=(ALL) NOPASSWD: /usr/bin/lsscsi apache ALL=(ALL) NOPASSWD: /usr/bin/lsscsi
apache ALL=(ALL) NOPASSWD: /tmp/restart-appliance.sh apache ALL=(ALL) NOPASSWD: /tmp/restart-appliance.sh
apache ALL=(ALL) NOPASSWD: /tmp/shutdown-appliance.sh apache ALL=(ALL) NOPASSWD: /tmp/shutdown-appliance.sh
apache ALL=(ALL) NOPASSWD: /usr/bin/systemctl reboot
apache ALL=(ALL) NOPASSWD: /usr/bin/systemctl poweroff

30
dist/adastra-vtl-installer/web-ui/api.php vendored
View File

@@ -566,23 +566,15 @@ function loadConfig() {
} }
function restartService() { function restartService() {
// Check if user has sudo privileges // Run systemctl restart in background to prevent PHP timeout/hanging
$output = []; // We strictly redirect output to /dev/null to ensure exec returns immediately
$returnCode = 0;
exec("sudo /usr/bin/systemctl restart mhvtl > /dev/null 2>&1 &");
exec('sudo systemctl restart mhvtl 2>&1', $output, $returnCode); echo json_encode([
'success' => true,
if ($returnCode === 0) { 'message' => 'Service restart initiated. Changes will take effect in a few seconds.'
echo json_encode([ ]);
'success' => true,
'message' => 'Service restarted successfully'
]);
} else {
echo json_encode([
'success' => false,
'error' => 'Failed to restart service: ' . implode("\n", $output)
]);
}
} }
function listTapes() { function listTapes() {
@@ -869,7 +861,7 @@ function restartAppliance() {
// Create a script to restart after a delay // Create a script to restart after a delay
$script = '#!/bin/bash $script = '#!/bin/bash
sleep 2 sleep 2
systemctl reboot /usr/bin/systemctl reboot
'; ';
$scriptPath = '/tmp/restart-appliance.sh'; $scriptPath = '/tmp/restart-appliance.sh';
@@ -889,7 +881,7 @@ function shutdownAppliance() {
// Create a script to shutdown after a delay // Create a script to shutdown after a delay
$script = '#!/bin/bash $script = '#!/bin/bash
sleep 2 sleep 2
systemctl poweroff /usr/bin/systemctl poweroff
'; ';
$scriptPath = '/tmp/shutdown-appliance.sh'; $scriptPath = '/tmp/shutdown-appliance.sh';
@@ -908,7 +900,7 @@ systemctl poweroff
function getDeviceMapping() { function getDeviceMapping() {
$output = []; $output = [];
// Get all SCSI devices with generic device names (sg) // Get all SCSI devices with generic device names (sg)
exec("lsscsi -g 2>&1", $output); exec("sudo /usr/bin/lsscsi -g 2>&1", $output);
// Filter for interesting devices (mediumx and tape) // Filter for interesting devices (mediumx and tape)
$devices = []; $devices = [];

30
web-ui/api.php
View File

@@ -566,23 +566,15 @@ function loadConfig() {
} }
function restartService() { function restartService() {
// Check if user has sudo privileges // Run systemctl restart in background to prevent PHP timeout/hanging
$output = []; // We strictly redirect output to /dev/null to ensure exec returns immediately
$returnCode = 0;
exec("sudo /usr/bin/systemctl restart mhvtl > /dev/null 2>&1 &");
exec('sudo systemctl restart mhvtl 2>&1', $output, $returnCode); echo json_encode([
'success' => true,
if ($returnCode === 0) { 'message' => 'Service restart initiated. Changes will take effect in a few seconds.'
echo json_encode([ ]);
'success' => true,
'message' => 'Service restarted successfully'
]);
} else {
echo json_encode([
'success' => false,
'error' => 'Failed to restart service: ' . implode("\n", $output)
]);
}
} }
function listTapes() { function listTapes() {
@@ -869,7 +861,7 @@ function restartAppliance() {
// Create a script to restart after a delay // Create a script to restart after a delay
$script = '#!/bin/bash $script = '#!/bin/bash
sleep 2 sleep 2
systemctl reboot /usr/bin/systemctl reboot
'; ';
$scriptPath = '/tmp/restart-appliance.sh'; $scriptPath = '/tmp/restart-appliance.sh';
@@ -889,7 +881,7 @@ function shutdownAppliance() {
// Create a script to shutdown after a delay // Create a script to shutdown after a delay
$script = '#!/bin/bash $script = '#!/bin/bash
sleep 2 sleep 2
systemctl poweroff /usr/bin/systemctl poweroff
'; ';
$scriptPath = '/tmp/shutdown-appliance.sh'; $scriptPath = '/tmp/shutdown-appliance.sh';
@@ -908,7 +900,7 @@ systemctl poweroff
function getDeviceMapping() { function getDeviceMapping() {
$output = []; $output = [];
// Get all SCSI devices with generic device names (sg) // Get all SCSI devices with generic device names (sg)
exec("lsscsi -g 2>&1", $output); exec("sudo /usr/bin/lsscsi -g 2>&1", $output);
// Filter for interesting devices (mediumx and tape) // Filter for interesting devices (mediumx and tape)
$devices = []; $devices = [];